[ds6-devel] nc6/src netsupport.c,NONE,1.1 netsupport.h,NONE,1.1 rt_config.c,NONE,1.1 rt_config.h,NONE,1.1 Makefile.am,1.6,1.7 network.c,1.20,1.21

[Chris Leishman]

On Sunday, December 29, 2002, at 04:12 PM, mauro@deepspace6.net wrote:

> Update of /cvs/nc6/src
>
> Modified Files:
> 	Makefile.am network.c
> Added Files:
> 	netsupport.c netsupport.h rt_config.c rt_config.h


Umm.... I'm not sure why you've added "is_ipv6_enabled" and 
"is_double_binding_sane"?

The "is_ipv6_enabled" is ok - but not very useful since this is handled 
in the code anyway (it detects when creating an ipv6 was attempted and 
failed due to lack of support).  At the moment your using it to 
determine whether to reorder ipv6 first in the getaddrinfo results - 
which isn't really necessary since reordering doesn't really hurt in 
any situation.

And "is_double_bind_sane" is a little dangerous IMHO, since it attempts 
a bind to 1025 - assuming it will be free, which isn't necessarily true.

Perhaps you need to explain all the logic behind it a bit more?

Regards,
Chris