[ds6-devel] CVS commits and coding style

[Chris Leishman]

Hi Mauro,

If possible, can you split up your CVS commits a bit more?  I think 
it's good to keep a record of what changes were made and the rationale, 
rather than just grouping them all together.  Eg. in the last commits 
you changed the connection_attributes interface completely (adding it 
accessor methods) and a few other code changes, but the log message 
doesn't really reflect that.  It would make it easier for me to see 
what went on and why.

Also, I noticed you cleaned up the style in a few places.  Thats cool, 
though in a few places I made the choice to bend the rules slightly for 
astetic purposes - eg. not lining up function call arguments properly 
so as to not run over line length.  Which is preferable?  I usually 
think that bending the rules a little is ok if it a significant 
difference for the better.

Also, I'm willing to accept that opening braces can be on the same line 
as the keyword (except in functions), but I would think that when it 
can't - because the keyword arguments take more than 1 line for example 
- that it should be on it's own line, lined up with the keyword.  The 
linux CodingStyle doesn't specifically mention this, though I think 
this is pretty common practice.  Can I add this to the README.Maint?

Regards,
Chris