[ds6-devel] ca refactor
Chris Leishman
chris at leishman.org
Mon Jan 6 02:49:02 CET 2003
Hi,
Once again I've done a little bit of refactoring, which I'm making
available for comment.
Basically, the commit I did earlier for cleaning up main and the
connection_attributes got me a little frustrated because I wasn't sure
if the ca was trying to just be an attribute store, or if it was trying
to be something more (because, for example, the io_streams were stored
in there). So, to clarify I've refactored a bit to do the following:
- Reduced connection_attributes to purely an attribute store. It just
stores the values to use for configuring everything (the buffer size,
etc) rather than configuring things directly.
- Reorganised main such that the buffers and io_streams and initialized
there, using values pulled from the ca for buffer size, mtu, nru, etc.
- Changed do_connect / do_listen so that instead of modifing the
remote_stream inside the ca, they just return the fd & socktype. main
(or actually a static establish_connection function) then sticks these
into the remote io_stream.
- Broke main up a bit more (main, connection_main, establish_connection
& run_transfer).
So anyway, as I'm not keen to just plaster everything with this until I
have some discussion (or just Mauro's approval anyway), I've put it
into one of my surely now infamous refactor branches. This ones
'chris_refactor_060103'.
Regards,
Chris
More information about the ds6-devel
mailing list