[ds6-devel] Re: [nc6-commit] nc6/src connection.h, 1.18, 1.19 misc.c, 1.21, 1.22 misc.h, 1.20, 1.21 network.c, 1.48, 1.49 parser.c, 1.56, 1.57

[Mauro Tortonesi]

On Friday 09 January 2004 00:30, Chris Leishman wrote:
> On Thu, Jan 08, 2004 at 06:18:56PM +0100, mauro at deepspace6.net wrote:
> > Update of /cvs/nc6/src
> >
> > Modified Files:
> > 	connection.h misc.c misc.h network.c parser.c
> > Log Message:
> > added bluez support. used SOMAXCONN as the backlog parameter in
> > listen(2). cleaned up definition of the long_options array.
>
> Hi Mauro!
>
> Couple of comments:
>
> 1. You should define SOMAXCONN using autoconf (patch attached - don't have
> my ssh key handy).

thanks, i will apply it tomorrow.


> 2. Can you give a bit of detail on the bluetooth stuff?  I noticed that you
> have defined totaly separate listen/connect function for IP and bluetooth -
> why is this needed?  I would have thought the code was AF independant
> enough (thats the points of AF independance).  

the problem with AF independance and bluez is that you can't resolve a bluez 
name with getaddrinfo. and this is quite a big problem...


> Also, the name do_connect_ip isn't really correct since it's generic code 
> (not required to be just ip).

right, but it's only a preliminary version ;-)


> 3. I don't see where HAVE_BLUEZ is defined?

in fact, i still have to code it :-P

-- 
Aequam memento rebus in arduis servare mentem...

Mauro Tortonesi			mauro at deepspace6.net
				mauro at ferrara.linux.it
Deep Space 6 - IPv6 on Linux	http://www.deepspace6.net
Ferrara Linux Users Group	http://www.ferrara.linux.it