[ipv6calc] Re: ipv6calc: new base85 implementation

[Peter Bieringer]

Hi Niko,

Niko Tyni schrieb:
> Hello Dr. Bieringer,
> 
> my name is Niko Tyni, and I'm planning to take over the maintenance of
> the Debian ipv6calc package, as Masamichi Goudge unfortunately doesn't
> have the time for that anymore.
> 
> First, I'd like to thank you for the nice tool you have created. It
> has been quite helpful to me in my work as a network engineer and 
> I appreciate the amount of work you have put into it.
> 
> While looking through the code, I noticed that while the licenses and the
> copyrights of the various pieces of code that come from other sources are
> excellently documented in general, there seems to be no information on
> the license of the RFC 1924 (base85 conversion) code in lib/librfc1924.c.

This is indeed right, I didn't find any information.

> I'm aware that the RFC is mostly an April 1st joke, and the code that
> lib/librfc1924.c is based on, samplecode/rfc1924-encode.c, is probably
> part of the joke. Still, I think it would make things cleaner if it was
> known without doubt that also this part of the code is free software.

For sure, also the old code was't be good enough to check with splint.

> To that end, I have rewritten the base85 implementation so that there is
> nothing left of the original code from rfc1924-encode.c.  This new code is
> naturally under the GNU General Public License (version 2, as all ipv6calc
> code.) Moreover, it is clearer (at least IMO :), 40 % shorter and about
> 400 times faster on my 32-bit hardware than the current implementation.

Thank you very much!

> You can find my implementation and the test code I used for the
> measurements at
> 
> http://www.helsinki.fi/~ntyni/ipv6calc/
> 
> Please consider replacing the current RFC 1924 implementation with this
> in a future release of ipv6calc.
> 
> (If you do this, please also consider removing the file
>  samplecode/rfc1924-encode.c from the ipv6calc distribution, as it
>  is in principle unknown whether anyone is allowed distribute it even
>  unmodified. Also, it would be good to update the LICENSE file to reflect
>  both this and possibly the past md5/OpenSSL change.)

Changes / replacement committed to CVS. Please give a try.

BTW: what do you mean with "past md5/OpenSSL change"? Did I miss something?

	Peter
-- 
Dr. Peter Bieringer                     http://www.bieringer.de/pb/
GPG/PGP Key 0x958F422D                       mailto:pb at bieringer.de
Deep Space 6 Co-Founder and Core Member  http://www.deepspace6.net/