Re: ipv6calc: new base85 implementation
Niko Tyni schrieb:
On Wed, Jun 07, 2006 at 03:47:54PM +0200, Peter Bieringer wrote:
BTW: switch in Makefile.in currently doesn't work for ipv6calc binary itself, I have troubles to inherit the information from main Makefile to ipv6calc/Makefile (perhaps one can lead me to proper implementation).
I'm not an autoconf guru, but I think an AC_ARG_ENABLE macro is the cleanest solution. A quick patch based on that is at
http://www.helsinki.fi/~ntyni/ipv6calc/ip2location.patch
It seems to work for me. I have no idea how specific to GNU make the 'ifeq' and the ':=' (needed for recursive expansion) constructs are, though.
I thought already about the same, thank you very much for your patch! BTW: I've fixed some build options bugs also, now it should be working fine. spec file for RPM was also updated to understand "--with ip2location" Here is a example about the output: $ ./ipv6calc/ipv6calc -p databases/IP2Location/C-IP2Location-1.1.0/data/IP-COUNTRY-SAMPLE.BIN -q -m -i 66.1.2.3 IPV4=66.1.2.3 IPV4_REGISTRY=ARIN IP2LOCATION_COUNTRY_SHORT=US IP2LOCATION_COUNTRY_LONG=UNITED STATES IP2LOCATION_REGION=This parameter is unavailable for selected data file. Please upgrade the data file. IP2LOCATION_CITY=This parameter is unavailable for selected data file. Please upgrade the data file. IP2LOCATION_ISP=This parameter is unavailable for selected data file. Please upgrade the data file. IP2LOCATION_LATITUDE=0.000000 IP2LOCATION_LONGITUDE=0.000000 IP2LOCATION_DOMAIN=This parameter is unavailable for selected data file. Please upgrade the data file. IP2LOCATION_ZIPCODE=This parameter is unavailable for selected data file. Please upgrade the data file. IPV6CALC_NAME=ipv6calc IPV6CALC_VERSION=0.52cvs IPV6CALC_COPYRIGHT="(P) & (C) 2001-2006 by Peter Bieringer <pb (at) bieringer.de>" So now it's on IP2Location side to provide an update for the C-API supporting IPv6. Peter -- Dr. Peter Bieringer http://www.bieringer.de/pb/ GPG/PGP Key 0x958F422D mailto:pb@bieringer.de Deep Space 6 Co-Founder and Core Member http://www.deepspace6.net/
On Wed, Jun 07, 2006 at 11:00:57PM +0200, Peter Bieringer wrote:
BTW: I've fixed some build options bugs also, now it should be working fine.
It looks good to me, FWIW. The only thing missing I can see is documenting the "-p" ip2location option in lib/ipv6calchelp.c Do you plan to release 0.52 soon? I'd like to have the new rfc1924 code in a release before I update the Debian package :) Cheers, -- Niko
participants (2)
-
Niko Tyni
-
Peter Bieringer