Re: [ipv6calc] New version 0.49 released [PATCH]
Hi Radek, --On Donnerstag, 15. September 2005 10:47 +0200 Radek Vokál <rvokal@redhat.com> wrote:
Hi Peter,
so here's the bug I found in your code. Seems like you overwrite the stack in ipv6addr_copy, because you shift the address by i in the stack and than you "successfully" copy the structure 48x times in the stack.
Ooops...wondering how it has ever worked.
So correct copying of the structure is just *dst = *src (this works as copy for structures so no need to do some memcpy stuff)
Thank you very much for the patch, confirmed working, submitted to CVS now. Looks like this was also the reason that -O2 causes problems, reenabled it now. I will release version 0.50 tonight MEST. Peter -- Dr. Peter Bieringer http://www.bieringer.de/pb/ GPG/PGP Key 0x958F422D mailto: pb at bieringer dot de Deep Space 6 Co-Founder and Core Member http://www.deepspace6.net/
participants (1)
-
Peter Bieringer