Hi Peter and other ipv6calc list members, here's a patch for 0.61.0 that adds the following 'configure' features: --enable-system-geoip Use the system GeoIP library instead of the bundled one (default: bundled) --enable-default-geoip-file=file Use a default GeoIP database file when ipv6calc is invoked with '-G' Additionally, it tries to detect the presence of the getopt library and uses the system one if possible. There are also tiny fixes for 'ipv6calc --help'. These are tweaks that would make the Debian packaging simpler. I'm currently patching the various Makefile.in files to get the system getopt and GeoIP in, and it would be nice if that could be configurable. I hope they would benefit other distributions as well. I added the new '-G' option for enabling GeoIP with a default database, so the users don't have to type the path every time when they want to use the only database provided by the system. Please consider applying this (and running autogen afterwards, of course). I can split it off into separate patches if you like, but the system-geoip and the default-geoip-file stuff overlap somewhat. I haven't been able to test the getopt stuff with a real system that doesn't have getopt in its libc, but I think it should work. Ultimately, I would like to have something like --with-geoip=/path/to/geoip-build-dir --with-ip2location=/path/to/ip2location-build-dir so there wouldn't be any need to bundle them inside the ipv6calc tarball, as users could "easily" include them into the build. Do you think this would be a good idea? I could prepare the patch if you like it... BTW, the bundled GeoIP code doesn't currently build due to files missing from <...>/GeoIP-1.3.17/apps : make[3]: *** No rule to make target `geoiplookup.o', needed by `geoiplookup'. Stop. Cheers, -- Niko Tyni ntyni@iki.fi
Ni Niko, (mail was on hold because of spam level) Niko Tyni schrieb:
Hi Peter and other ipv6calc list members,
here's a patch for 0.61.0 that adds the following 'configure' features:
--enable-system-geoip Use the system GeoIP library instead of the bundled one (default: bundled) --enable-default-geoip-file=file Use a default GeoIP database file when ipv6calc is invoked with '-G'
Additionally, it tries to detect the presence of the getopt library and uses the system one if possible. There are also tiny fixes for 'ipv6calc --help'.
Thank you, I've migrated your patch into current CVS version. Could you please check it. BTW: looks like GeoIP does not include their API version in the header files...
I haven't been able to test the getopt stuff with a real system that doesn't have getopt in its libc, but I think it should work.
People should test it.
Ultimately, I would like to have something like
--with-geoip=/path/to/geoip-build-dir --with-ip2location=/path/to/ip2location-build-dir
so there wouldn't be any need to bundle them inside the ipv6calc tarball, as users could "easily" include them into the build. Do you think this would be a good idea? I could prepare the patch if you like it...
Please contribute.
BTW, the bundled GeoIP code doesn't currently build due to files missing from <...>/GeoIP-1.3.17/apps :
make[3]: *** No rule to make target `geoiplookup.o', needed by `geoiplookup'. Stop.
Should be fixed in current CVS. Regards, Peter -- Dr. Peter Bieringer http://www.bieringer.de/pb/ GPG/PGP Key 0x958F422D mailto:pb@bieringer.de Deep Space 6 Co-Founder and Core Member http://www.deepspace6.net/
participants (2)
-
Niko Tyni
-
Peter Bieringer